Skip to content

fix(ballot): give the ballot bubbles an explicit text colour #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masiarek wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ballot): give the ballot bubbles an explicit text colour #1534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/frontend/src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,17 @@ code {
cursor: pointer;
}

/* A <button> does not inherit .ballot's color — it takes the UA stylesheet's
ButtonText. That is black on desktop and Android, which is why nobody set a
colour here, but on iOS WebKit it resolves to the system tint and the score
digits came out blue (#1272) — including inside filled bubbles, where the
digit is meant to disappear against the black fill. Stating the colour makes
every platform render what desktop already did. */
.circle,
.oval {
color: var(--brand-black);
}

.circle.filled,
.oval.filled {
background-color: black;
Expand Down
Loading