Conversation
`npm run build` failed on three pre-existing `tsc` errors, which made the
PR CI check red on every pull request.
claims.tsx: `<Txt>` children must be strings, but the circle labels passed
`{i+1}`, a number (TS2322). Wrapped in a template literal.
newFile.tsx: `<Image>` resolved to the DOM global `HTMLImageElement` rather
than a motion-canvas node, which is not a valid JSX component here (TS2786,
plus a TS2322 prop mismatch). The file was an untouched editor scaffold --
default filename, no accompanying .meta, not registered in project.ts, and
it rendered an Img with no src -- so it is deleted rather than repaired.
Also drops the NOTE in the PR CI workflow that documented these failures as
known-red, since the check now passes.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AXS6r9VQZwHUj1P4pLJwa9
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
buildjob in run 34636758080.npm run build(tsc && vite build) failed on three pre-existingtscerrors, so the PR CI check added in #14 was red on every pull request and could not gate anything.src/scenes/claims.tsx<Txt>children must be strings, but the numbered circle labels passed{i+1}— a number (TS2322). Wrapped in a template literal; no rendered output changes.src/scenes/newFile.tsx(deleted)<Image>resolved to the DOM globalHTMLImageElementrather than a motion-canvas node, which is not a valid JSX component in this project (TS2786, plus a TS2322 prop mismatch) — the intended element wasImgfrom@motion-canvas/2d.Rather than repair it, the file is deleted. It was an untouched editor scaffold: default filename, no accompanying
.meta(every other scene has one), not registered insrc/project.ts, and it rendered anImgwith nosrc. Nothing references it..github/workflows/pr-ci.ymlDrops the
NOTEcomment documenting these failures as known-red, now that the check passes.Verification
npm run buildsucceeds locally:🤖 Generated with Claude Code
https://claude.ai/code/session_01AXS6r9VQZwHUj1P4pLJwa9