Skip to content

Fix TypeScript errors breaking the build - #15

Open
3uzbcqje wants to merge 1 commit into
mainfrom
fix/build-typescript-errors
Open

3uzbcqje wants to merge 1 commit into
mainfrom
fix/build-typescript-errors

Conversation

@3uzbcqje

Copy link
Copy Markdown
Contributor

Fixes the build job in run 34636758080.

npm run build (tsc && vite build) failed on three pre-existing tsc errors, so the PR CI check added in #14 was red on every pull request and could not gate anything.

src/scenes/claims.tsx

<Txt> children must be strings, but the numbered circle labels passed {i+1} — a number (TS2322). Wrapped in a template literal; no rendered output changes.

src/scenes/newFile.tsx (deleted)

<Image> resolved to the DOM global HTMLImageElement rather than a motion-canvas node, which is not a valid JSX component in this project (TS2786, plus a TS2322 prop mismatch) — the intended element was Img from @motion-canvas/2d.

Rather than repair it, the file is deleted. It was an untouched editor scaffold: default filename, no accompanying .meta (every other scene has one), not registered in src/project.ts, and it rendered an Img with no src. Nothing references it.

.github/workflows/pr-ci.yml

Drops the NOTE comment documenting these failures as known-red, now that the check passes.

Verification

npm run build succeeds locally:

✓ 1046 modules transformed.
dist/project-8597d1dc.js     151.31 kB │ gzip: 47.97 kB
✓ built in 1.76s

🤖 Generated with Claude Code

https://claude.ai/code/session_01AXS6r9VQZwHUj1P4pLJwa9

`npm run build` failed on three pre-existing `tsc` errors, which made the
PR CI check red on every pull request.

claims.tsx: `<Txt>` children must be strings, but the circle labels passed
`{i+1}`, a number (TS2322). Wrapped in a template literal.

newFile.tsx: `<Image>` resolved to the DOM global `HTMLImageElement` rather
than a motion-canvas node, which is not a valid JSX component here (TS2786,
plus a TS2322 prop mismatch). The file was an untouched editor scaffold --
default filename, no accompanying .meta, not registered in project.ts, and
it rendered an Img with no src -- so it is deleted rather than repaired.

Also drops the NOTE in the PR CI workflow that documented these failures as
known-red, since the check now passes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AXS6r9VQZwHUj1P4pLJwa9
@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 8380f9c3-5c5a-4af2-95e9-67a2493ff661


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant