Add PR CI workflow - #31
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Nothing currently verifies a pull request in this repo: the existing workflows run on push to the default branch, after the merge. That makes dependency bumps unreviewable in practice -- a Dependabot PR looks green because nothing is checking it. This adds a pull_request-triggered build. Actions are pinned by commit SHA and checkout runs with persist-credentials: false, matching the convention used elsewhere in the org and satisfying the zizmor audit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LpZM2dqedR4fXiLn7272XQ
3uzbcqje
force-pushed
the
chore/pr-ci
branch
from
September 11, 2026 19:02
b5a3839 to
f1b44b5
Compare
src/App.test.js still asserted on the stock Create React App "learn react" link, which this app has never rendered, so the suite had been red since the app was first written and no test step could be enabled. Replace it with a smoke test that mounts the component tree and asserts something rendered. That is a low bar, but it is the bar a dependency bump trips: an upgrade that still compiles but breaks rendering yields a blank page, which a build-only check cannot see. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LpZM2dqedR4fXiLn7272XQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
pull_request-triggered build. Right now nothing in this repo verifies a PR at all — the existing workflows run onpushto the default branch, after the merge. That is what makes the Dependabot PRs unreviewable: they look green because nothing is checking them.Status
✅ Green, confirmed by this PR's own CI run, not just locally.
Notes
CI: "false"on the build step.react-scriptspromotes lint warnings to build errors wheneverCI=true, which GitHub Actions sets automatically. My local run could not catch this (noCIvar set); the first run of this workflow did. There are only 5, all trivial: 3×eqeqeq(==instead of===) and 2 unused imports (useState,useEffect). Clear the warnings and drop that line to get the strict behaviour back.src/App.test.jsstill asserted on the stock Create React Applearn reactlink, which this app has never rendered, so the suite had been red since the app was written. It is replaced with a smoke test that mounts the component tree and asserts.appand.componentsrendered — a low bar, but the bar a dependency bump trips: an upgrade that still compiles but breaks rendering yields a blank page, which a build-only check cannot see. Verified:npm ci→ build → 1/1 test passes.--watchAll=falseexplicitly rather than relying on theCIvariable, which would otherwise drop react-scripts into interactive watch mode and hang the job.Conventions
Equal-Vote/terraform.persist-credentials: falseon checkout — otherwise the job token is left in.git/config, which the zizmorartipackedaudit flags. Nothing here pushes.permissions: contents: read— least privilege.concurrencywithcancel-in-progress, so a new push supersedes the in-flight run.Every deviation above is explained inline in the workflow file, so the next person does not have to rediscover it.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LpZM2dqedR4fXiLn7272XQ