Add PR CI workflow and commit package-lock.json - #11
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Nothing currently verifies a pull request in this repo: the existing workflows run on push to the default branch, after the merge. That makes dependency bumps unreviewable in practice -- a Dependabot PR looks green because nothing is checking it. This adds a pull_request-triggered build. Actions are pinned by commit SHA and checkout runs with persist-credentials: false, matching the convention used elsewhere in the org and satisfying the zizmor audit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LpZM2dqedR4fXiLn7272XQ
3uzbcqje
force-pushed
the
chore/pr-ci
branch
from
September 11, 2026 19:02
7670306 to
4bebfe1
Compare
No lockfile was committed, so `npm ci` could not run, the setup-node npm cache was unavailable, and Dependabot had nowhere to pin transitive dependencies -- it could only ever update the ranges in package.json. Verified: npm ci from a clean tree, then npm run build, both pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LpZM2dqedR4fXiLn7272XQ
This repo has never had one. The initial import came out of CodeSandbox without it, so nothing has ever guarded against committing a local install or a build output. Standard create-react-app contents, matching react-scripts 3.0.1. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011x8VhZvLikFVF7op6i4fm3
import data from "./simple.csv" does not resolve to the file's contents under Create React App's jest config. An unknown extension goes through fileTransform, which resolves the import to the filename string "simple.csv", so parse() was handed a filename, returned null, and the test failed on "Cannot read properties of null". It had never passed. Read the fixture from disk instead. All 9 tests pass, and CI now runs them. The domain assertion was correct all along -- Dylan and Eliza do win. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LpZM2dqedR4fXiLn7272XQ
3uzbcqje
force-pushed
the
chore/pr-ci
branch
from
September 14, 2026 01:08
97f0f25 to
59d8168
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
pull_request-triggered build. Right now nothing in this repo verifies a PR at all — the existing workflows run onpushto the default branch, after the merge. That is what makes the Dependabot PRs unreviewable: they look green because nothing is checking them.Status
✅ Green, confirmed by this PR's own CI run, not just locally.
Notes
npm ci, from thepackage-lock.jsonthis PR now commits. Without one,npm cicould not run, the setup-node npm cache was unavailable, and Dependabot could only ever update the ranges inpackage.json— it had nowhere to pin transitive dependencies. Verified:npm cifrom a clean tree, thennpm run build, both pass.NODE_OPTIONS=--openssl-legacy-provider: webpack 4 hashing vs OpenSSL 3 on modern Node.CI: "false"on the build step.react-scriptspromotes lint warnings to build errors wheneverCI=true, which GitHub Actions sets automatically. My local run could not catch this (noCIvar set); the first run of this workflow did. Clear the warnings and drop that line to get the strict behaviour back.test1 tie breakinghad never passed, but not for a domain reason:import data from "./simple.csv"resolves to the filename string"simple.csv"under Create React App's jest config (unknown extensions go throughfileTransform), soparse()was handed a filename and returnednull. The fixture is now read from disk withfs.readFileSync. The assertion itself was correct all along — Dylan and Eliza do win. Verified:npm ci→npm run build→ 9/9 tests pass.--watchAll=falseexplicitly rather than relying on theCIvariable, which would otherwise drop react-scripts into interactive watch mode and hang the job.Conventions
Equal-Vote/terraform.persist-credentials: falseon checkout — otherwise the job token is left in.git/config, which the zizmorartipackedaudit flags. Nothing here pushes.permissions: contents: read— least privilege.concurrencywithcancel-in-progress, so a new push supersedes the in-flight run.Every deviation above is explained inline in the workflow file, so the next person does not have to rediscover it.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LpZM2dqedR4fXiLn7272XQ