Skip to content

fix: Idefics3 encoder cache panic when do_image_splitting is enabled #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romnn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Idefics3 encoder cache panic when do_image_splitting is enabled #2074

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions mistralrs-core/src/vision_models/idefics3/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,16 @@ impl Idefics3Model {

let pixel_values = pixel_values.to_dtype(self.dtype)?;

// Get seq from vision encoder + connector, with per-image caching
let image_hidden_states = if !image_hashes.is_empty() {
let n = pixel_values.dim(0)?;
// Get seq from vision encoder + connector, with per-image caching.
//
// When do_image_splitting is enabled, each user image is split into
// N sub-images (grid tiles + one global resize), so pixel_values has
// more entries than image_hashes (one hash per original user image).
// Per-image caching is only valid when the counts match 1:1.
let n = pixel_values.dim(0)?;
let image_hidden_states = if !image_hashes.is_empty()
&& image_hashes.len() == n
{
let mut per_image: Vec<Option<Tensor>> = vec![None; n];
let mut miss_indices: Vec<usize> = Vec::new();
{
Expand Down