Skip to content

fix: more version alignment#161

Merged
jasongdove merged 2 commits into
mainfrom
fix/more-version-alignment
May 23, 2026
Merged

fix: more version alignment#161
jasongdove merged 2 commits into
mainfrom
fix/more-version-alignment

Conversation

@jasongdove

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces versioning metadata into the Docker build process by adding ARG and ENV instructions to the Dockerfile. A review comment correctly identifies that placing these instructions before the dependency compilation step invalidates the Docker layer cache, which significantly increases build times. It is recommended to move these declarations after the cargo chef cook step to optimize the build process and maintain efficient caching.

Comment thread docker/Dockerfile Outdated
@jasongdove jasongdove merged commit 126e5a0 into main May 23, 2026
8 checks passed
@jasongdove jasongdove deleted the fix/more-version-alignment branch May 23, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant