Skip to content

feat: add more data to dossier#162

Merged
jasongdove merged 2 commits into
mainfrom
feat/more-dossier-data
May 24, 2026
Merged

feat: add more data to dossier#162
jasongdove merged 2 commits into
mainfrom
feat/more-dossier-data

Conversation

@jasongdove

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Dossier creation process by introducing a DossierBuilder and making several fields optional. It also implements Serialize for various media and hardware acceleration structures within the ffpipeline crate, including custom serialization for VAAPI capabilities to improve readability. Feedback focuses on simplifying the DossierBuilder logic by implementing Default for the MediaInfo struct and utilizing get_or_insert_with to reduce boilerplate in the builder methods.

Comment thread crates/ersatztv-channel/src/dossier.rs Outdated
Comment thread crates/ersatztv-channel/src/dossier.rs Outdated
Comment thread crates/ersatztv-channel/src/dossier.rs Outdated
Comment thread crates/ersatztv-channel/src/dossier.rs Outdated
@jasongdove jasongdove merged commit aa44dae into main May 24, 2026
8 checks passed
@jasongdove jasongdove deleted the feat/more-dossier-data branch May 24, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant