feat: add more data to dossier#162
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the Dossier creation process by introducing a DossierBuilder and making several fields optional. It also implements Serialize for various media and hardware acceleration structures within the ffpipeline crate, including custom serialization for VAAPI capabilities to improve readability. Feedback focuses on simplifying the DossierBuilder logic by implementing Default for the MediaInfo struct and utilizing get_or_insert_with to reduce boilerplate in the builder methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.