fix: cuda optimizations#165
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an eager conversion to 8-bit pixel formats when it enables the use of a hardware overlay filter. It also restructures how decoder filters are prepended to the filter chain to handle CUDA's hardware upload workaround. The review feedback suggests optimizing the eager conversion logic by checking if the input frame's bit depth is actually greater than 8 before performing the analysis, which avoids redundant state cloning and evaluation when the input is already 8-bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optimizes cuda pipeline to convert to 8-bit early when encoder is 8-bit and hardware overlay can be used with 8-bit, instead of downloading and using software overlay with 10-bit content that will later be converted to 8-bit anyway.