Skip to content

feat: add dynamic item source#167

Merged
jasongdove merged 2 commits into
mainfrom
feat/item-source-dynamic
May 31, 2026
Merged

feat: add dynamic item source#167
jasongdove merged 2 commits into
mainfrom
feat/item-source-dynamic

Conversation

@jasongdove

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for dynamic playout items, allowing PlayoutItem JSON documents to be fetched over HTTP(S) at playback time. It adds reqwest as a dependency, updates the playout schema, and implements resolution logic within ChannelSession to handle template expansion, request headers, and recursion prevention. Feedback on the changes points out critical compilation errors in resolve_dynamic_item where the code attempts to move non-Copy fields out of shared references (specifically within the tracks and watermark checks); using references instead of direct moves is recommended to resolve these errors.

Comment thread crates/ersatztv-channel/src/channel_session.rs
Comment thread crates/ersatztv-channel/src/channel_session.rs
@jasongdove jasongdove merged commit 762057d into main May 31, 2026
8 checks passed
@jasongdove jasongdove deleted the feat/item-source-dynamic branch May 31, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant