Skip to content

feat: add probe hint to spec to avoid probing before playback#168

Merged
jasongdove merged 1 commit into
mainfrom
feat/probe-hint
Jun 3, 2026
Merged

feat: add probe hint to spec to avoid probing before playback#168
jasongdove merged 1 commit into
mainfrom
feat/probe-hint

Conversation

@jasongdove

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces 'probe hints' (ProbeHint, VideoHint, AudioHint) to bypass running ffprobe on playout items when metadata is already known, updating the playout schema to version 0.0.2. Feedback on these changes suggests optimizing serialization by omitting empty profiles, reducing unnecessary string allocations with as_deref(), and avoiding eager string allocation using or_else instead of or.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread crates/ersatztv-playout-generator/src/generate.rs
Comment thread crates/ersatztv-channel/src/channel_session.rs
Comment thread crates/ersatztv-channel/src/channel_session.rs
@jasongdove jasongdove merged commit b1d53ec into main Jun 3, 2026
8 checks passed
@jasongdove jasongdove deleted the feat/probe-hint branch June 3, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant