fix(changelog): remap stale SHAs in-memory to survive ctx exit dump#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_resolve_stale_shasdetected stale SHAs after rebase and applied corrections via file-level regex replacement. Butpkg_ctx.__exit__unconditionally re-dumpsself._actions(still holding old SHAs), overwriting the file fix. A secondary issue: the regex_SHORT_SHA_PATTERNcouldn't handle YAML-quoted SHA values.Switched to in-memory operations:
apply_remap_to_actionsmutatesFixAction.short_shadirectly onctx._actions, andremove_actions_by_shafilters the list. When__exit__dumps, it writes corrected SHAs. Removed dead file-level functions (apply_remap_to_file,remove_actions_from_file) and_SHORT_SHA_PATTERN.Considerations
apply_remap_to_actionsmutates in-place (returns count);remove_actions_by_shareturns a new list. Callers must assign the result ofremove_actions_by_shaback toctx._actions