fix(api-diff): strip class tags in type normalization to avoid false-positive diffs#23
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 79.87% 79.99% +0.11%
==========================================
Files 80 80
Lines 4990 5033 +43
==========================================
+ Hits 3986 4026 +40
- Misses 1004 1007 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix false-positive type-change diffs caused by
<class '...'>tags in type annotations.Some Python introspection paths produce type strings wrapped in
<class 'module.Name'>(e.g., fromrepr()of type objects). These were not normalized before comparison, causingnormalize_typeto report spuriousPARAM_TYPE_CHANGEDdiffs when comparing baseline and dev API dumps.The fix strips
<class '...'>tags before applying qualified-name normalization, so<class 'ask_shell._internal.models.ShellRun'>correctly matchesShellRun.