fix: improve navbar responsiveness and layout across all devices (closes #512)#524
Conversation
Eswaramuthu#512) - Restructured base.html navbar markup to house both the theme toggle button and hamburger menu in a unified `.nav-right` wrapper. - Relocated theme toggle element inside the main header markup instead of absolute floating, resolving overlap bugs on mobile. - Updated styles.css media queries to collapse the navigation menu under `992px` (tablet width) instead of `768px`, preventing link wrapping and overflows on intermediate screens. - Styled mobile navigation toggle active animations to morph the hamburger bars into an "X" when open. - Configured max-height and overflow scroll behaviour for the mobile navigation drawer to prevent links from getting cut off on small viewports. - Configured DB_PATH on the Flask application instance so tests run and resolve database tables correctly.
|
Someone is attempting to deploy a commit to the 007's projects Team on Vercel. A member of the Team first needs to authorize it. |
Thanks for creating a PR for your Issue!
|
Confidence Score: 3/5 - Review RecommendedNot safe to merge without review — while this PR successfully improves navbar responsiveness across breakpoints, it introduces a correctness bug where the Lenis smooth-scroll offset in Key Findings:
Files requiring special attention
|
Summary
Closes #512
Implements standard responsive layouts, micro-animations, and clean controls for the main website header:
templates/base.htmlto place both the theme toggle button and the hamburger menu inside a unified.nav-rightcontainer. This relocates the theme toggle inside the normal header flow, avoiding previous fixed-position overlaps.static/styles.cssfrom768pxto992px(standard tablet width). This prevents the horizontal links list from wrapping onto multiple rows and overflowing the navbar border on intermediate/medium viewports.width: 100%from the brand name element (.nav-brand) on mobile viewports to prevent it from squeezing adjacent elements, and configuredmax-heightand vertical scrolling on the mobile menu list to support short screens or landscape viewports.DB_PATH, resolving aKeyErrorthat was failing database test assertions.Files Changed
templates/base.html.nav-rightwrapper, update active event listener logicstatic/styles.css992px, add hamburger X-morph transitions, adjust brand/right layoutapp.pyDB_PATHin application config to support database test suite