Adzikri#23
Conversation
still in progress...
Completion
HELLOW PRISMA!
Ada beberapa eslint rule yang saya matikan, karena berbentrokan dengan typescript : - import/unresolved - import/extensions
wkkwk hmpir lupa sama coursenya
- AddMiddlewares decortaor register humoungous number of middlewares - Dfs walk trying to import non javascript files - remove herobrine
There was a problem hiding this comment.
ini lu bikin router versi sendiri ?
There was a problem hiding this comment.
ini jugaa, buat apa fungsinya
zexoverz
left a comment
zexoverz
left a comment
There was a problem hiding this comment.
ini semacam lu nambahin sistem register router ya, biar kalo ada router baru tinggal di regist aja.
| import UserService from '../../../../services/user'; | ||
| import ApiError from '../../../../lib/utils/ApiError'; | ||
| import TokenService from '../../../../services/generateToken'; | ||
| import { AddMiddleware } from '../../../../lib/utils/RouterDecorator'; | ||
| import ValidationMiddleware from '../../../../lib/middlewares/ValidationMiddleware'; | ||
| import AuthValidation from '../../../../lib/validations/AuthValidations'; | ||
|
|
||
| @AddMiddleware(ValidationMiddleware.validate(AuthValidation.register)) | ||
| export default class extends RouterBuilder { | ||
| public static override async controller(req: Request, res: Response) { | ||
| const existing = await UserService.getEmail(req.body.email); |
There was a problem hiding this comment.
oke pas lihat ini paham gua, cuman bedain cara ngebuat route nya aja ya.
zexoverz
left a comment
zexoverz
left a comment
There was a problem hiding this comment.
Gua approve walaupun beda struktur, selama lu paham pake sturktur lu.
oiya tambahin readme.md dan kasih alasan kenapa pake RouterBuilder, biar yang lain juga bisa belajar
- Menyelesaikan Semua CRUD - System Quantity stock - Api search menggunakan category /v1/products/search - Pagination untuk semua getAll api - Hanya admin yang dapat mengakses /v1/users
zexoverz
left a comment
zexoverz
left a comment
There was a problem hiding this comment.
Nice document, lanjutkan
work in progress...
still in progresss...
still in progresss...
Now with responses and more
|
mohon reviewnya sir, test suite dan dokumentasi sudah saya kerjakan |
zexoverz
left a comment
zexoverz
left a comment
There was a problem hiding this comment.
Dokumentasi Approved, sorry gua baru review
|
Congrats dzikrifauzi, selamat atas kelulusannya di phase 1 🔥 🔥 🔥 overall nilai lu di phase 1 ada di angka 98% (hampir sempurna), penilaian ini base on: Review: untuk open gate phase 2 nanti di umumin jadwalnya, standby aja. bisa explore backend lagi kalau tertarik mau jadi backend developer : |
2 participants
Week 4. still in progress.