Skip to content

Move loading from persistent layer from PageView to PageDataManager & fix problems with quick nav #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ethran wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Move loading from persistent layer from PageView to PageDataManager & fix problems with quick nav #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e129619
improve page loading and error handling in EditorView and EditorViewM…
Ethran Mar 15, 2026
6b1c628
improve page lifecycle management and scrubber navigation stability -…
Ethran Mar 17, 2026
07fd57e
improve page lifecycle management and scrubber navigation stability -…
Ethran Mar 19, 2026
d845696
refactor editor settings persistence and improve canvas stability
Ethran Mar 21, 2026
10b9748
persist toolbar state changes in EditorViewModel
Ethran Mar 21, 2026
4a14a10
Change `PageDataManager` to a singleton from Object, move logic conne…
Ethran Mar 22, 2026
f9673c6
compilot sugestions
Ethran Mar 22, 2026
ccbac8d
refactor background management and comment out notebook repair logic
Ethran Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions app/src/main/java/com/ethran/notable/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ var SCREEN_HEIGHT = EpdController.getEpdWidth().toInt()
@AndroidEntryPoint
class MainActivity : ComponentActivity() {

// Delay the init till we have the permisions required
// Delay the init till we have the permissions required
@Inject
lateinit var kvProxy: dagger.Lazy<KvProxy>

Expand All @@ -70,13 +70,15 @@ class MainActivity : ComponentActivity() {
@Inject
lateinit var editorSettingCacheManager: dagger.Lazy<EditorSettingCacheManager>

// 1. Use dagger.Lazy to defer DB initialization until after permissions
@Inject
lateinit var appRepositoryLazy: dagger.Lazy<AppRepository>

@Inject
lateinit var exportEngineLazy: dagger.Lazy<ExportEngine>

@Inject
lateinit var pageDataManager: dagger.Lazy<PageDataManager>

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
enableFullScreen()
Expand All @@ -92,7 +94,6 @@ class MainActivity : ComponentActivity() {
val snackState = SnackState()
snackState.registerGlobalSnackObserver()
snackState.registerCancelGlobalSnackObserver()
PageDataManager.registerComponentCallbacks(this)

setContent {
var isInitialized by remember { mutableStateOf(false) }
Expand All @@ -106,9 +107,10 @@ class MainActivity : ComponentActivity() {
?: AppSettings(version = 1)

GlobalAppSettings.update(savedSettings)

editorSettingCacheManager.get().init()
strokeMigrationHelper.get().reencodeStrokePointsToSB1()
pageDataManager.get()
.registerComponentCallbacks(this@MainActivity.applicationContext)
editorSettingCacheManager.get().init()
}
}
isInitialized = true
Expand All @@ -120,7 +122,6 @@ class MainActivity : ComponentActivity() {
NotableApp(
// Call .get() here so they are only instantiated AFTER the permission check runs
exportEngine = exportEngineLazy.get(),
editorSettingCacheManager = editorSettingCacheManager.get(),
snackState = snackState,
appRepository = appRepositoryLazy.get()
)
Expand Down
Loading
Loading