fix: 🐛 Fix show-password toggle in PasswordField#56
Open
wapec wants to merge 2 commits into
Open
Conversation
Member
|
I like the removal of the more convoluted logic for the icon - when out of draft? @wapec |
- Fix input type typo ('type' → 'text')
- Show toggle on iOS with platform-specific icons
Signed-off-by: Bohdan Baranov <wapec@icloud.com>
- Add flex layout for toggle alignment - Set minimum icon dimensions Signed-off-by: Bohdan Baranov <wapec@icloud.com>
f684d15 to
fcf7b53
Compare
Author
|
thanks @moodyjmz . I have just cleaned up the commits and split into two changelog entries. PR is ready for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan
Show / hide toggle — visibility
Show / hide toggle — behaviour
••••••)test123456) — still masked(input had
type="type", an invalid value)Layout
Submit flow (sanity)
Tested on
Screenshots