fix: restore icons missed when dropping PNG sprite support#67
Merged
Conversation
After the PNG sprite removal, `<i class="toolbar__icon btn-xxx">` elements in RightMenu, StatusBar, and CellEditor templates had no CSS backing them. The Button component only generates SVG icons when rendering fresh HTML via parentEl; when setElement+render is used (as these views all do), the existing template markup is kept as-is. Replace all affected `<i>` elements with `<svg class="icon uni-scale"><use href="#btn-xxx"></use></svg>` to match the SVG sprite approach now used everywhere else. Fixes #65 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
ListView item templates in Animation.js and AnimationDialog.js were rendering animation icons as bare <div class="toolbar__icon animation-*"> elements, which lost their styles when the PNG spritesheets were removed. Replace with <svg><use href="#..."> to match the SVG sprite approach. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
<div class="toolbar__icon btn-xxx"> had no CSS backing after PNG sprite removal. Wrap an SVG sprite reference inside the existing div. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Dynamically created <div class="toolbar__icon btn-xxx"> elements had no CSS backing. Embed SVG sprite reference inside the div wrapper. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Inline <i> elements in the preview controls template had no CSS backing. Replace with SVG sprite references. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Inline <i>/<span> elements with toolbar__icon classes had no CSS backing. Replace with SVG sprite references in LanguageDialog, ShortcutsDialog, and ShortcutsEditDialog. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Inline <i> elements in the document editor StatusBar language menu and the spreadsheet AutoFilter tree view had no CSS backing. Replace with SVG sprite references. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
Missed in previous commit due to filename case (Statusbar.js). Replace the inline <i> icon with an SVG sprite reference. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
emberfiend
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65
<i class="toolbar__icon btn-xxx">elements in several templates had no CSS backing after the PNG spritesheets were removed. Replaces them with<svg><use href="#btn-xxx">(the approach used everywhere else) in the places that were missed: