fix: correct animation panel icon sizing in presentation editor#68
Closed
moodyjmz wants to merge 0 commit into
Closed
fix: correct animation panel icon sizing in presentation editor#68moodyjmz wants to merge 0 commit into
moodyjmz wants to merge 0 commit into
Conversation
moodyjmz
force-pushed
the
fix/presentation-click-offset
branch
from
e68710a to
64e9f5d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Animation effect icons in the presentation editor were rendering at 300px wide, causing click targets to be offset from their visual position.
Issue:
<svg class="icon uni-scale">has no dimensions — the.icon:not(svg)rule incombo-dataview.lessexplicitly excludes SVG elements from the icon size constraint, so the SVG defaulted to the browser's 300px intrinsic width.Fix: Use explicit
width="28" height="28"SVG attributes inAnimation.jsandAnimationDialog.js, matching theviewBox="0 0 28 28"of the animation symbols. No CSS class is used, which also avoidsfill: currentColoroverriding the icons' explicit colours.🤖 Generated with Claude Code