fix: correct animation panel icon sizing in presentation editor#69
Conversation
SVG icons in the animation effect picker were rendering at 300px wide (browser default) because the .icon:not(svg) CSS rule explicitly excludes SVG elements from the icon size constraint, and the icon uni-scale class has no dimensions of its own. Replace with explicit width="28" height="28" matching the 28x28 viewBox. This also avoids fill:currentColor overriding the icons' explicit fill colours. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
chrip
left a comment
chrip
left a comment
There was a problem hiding this comment.
Thanks for the fix—this is a clean, targeted change and the PR description clearly explains the root cause.
Minor side note: the branch name fix/presentation-click-offset doesn't quite match the content, but that's trivial.
LGTM. The explicit width/height on the <svg> elements is the right approach and avoids the CSS selector gap (:not(svg)) that was causing the 300px overflow. Approved.
chrip
left a comment
chrip
left a comment
There was a problem hiding this comment.
Thanks for the fix—this is a clean, targeted change and the PR description clearly explains the root cause.
Minor side note: the branch name fix/presentation-click-offset doesn't quite match the content, but that's trivial.
LGTM. The explicit width/height on the <svg> elements is the right approach and avoids the CSS selector gap (:not(svg)) that was causing the 300px overflow. Approved.
2 participants
SVG icons in the animation effect picker were rendering at 300px wide (browser default) because the .icon:not(svg) CSS rule explicitly excludes SVG elements from the icon size constraint, and the icon uni-scale class has no dimensions of its own.
Replace with explicit width="28" height="28" matching the 28x28 viewBox. This also avoids fill:currentColor overriding the icons' explicit fill colours.