Skip to content

MBP-247: Position Recovery Improvements - #44

Merged
federrg merged 16 commits into
masterfrom
MBP-247-Position-Recovery-Improvements
Jun 22, 2026
Merged

federrg merged 16 commits into
masterfrom
MBP-247-Position-Recovery-Improvements

Conversation

@aslanliafichev

Copy link
Copy Markdown
Collaborator

No description provided.

mac-kan and others added 3 commits March 3, 2026 14:48
Adds an additional restore position state to E_RestorePosition.
Add persistent variable in the GVL to store the current date and time
at shutdown.
Add homing status of axis before shutdown.
ST_AxisPersistent is extended to include axis status
variables to be saved before power failure.
Remove the enums eRestoreWithHome and eRestoreWithoutHome.
Only keep the persistent variables that are required
for the position recovery.

@szilard-ess szilard-ess left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I was working on a different project, I encountered that the following comment in ST_AxisConfig is not correct. This should be updated for the new process, the end of the comment implies a different type.

eRestorePosition: E_RestorePosition; //Option to restore incremental axis position after power loss(0 = No, 1 = Yes)

DUTs/Axis_Structures/ST_AxisConfig - Line 12

Update the description of the E_RestorePosition in
ST_AxisConfig and the DUT.
Comment thread DUTs/E_RestorePosition.TcDUT Outdated
Uses encoder reference system to decide restore type.
Keeps only the check for whether restore is needed.
Comment thread DUTs/Axis_Structures/ST_AxisStatus.TcDUT Outdated
Remove double semicolon from bAxisHasBeenRestored.
Comment thread GVLs/GVL.TcGVL Outdated

@szilard-ess szilard-ess left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works, see PR17 of tc_generic_structure for more info

@federrg

federrg commented Jun 17, 2026 •

Copy link
Copy Markdown
Member

HI @aslanliafichev , I remember a lot of back and forth about the requirements of this ticket. That we discover that some functionality described in the requirements in the ticket was not necessary or it did not make sense functional wise. Could you please describe here: https://confluence.ess.eu/spaces/MCAG/pages/952113567/Position+Recovery+PROG what is the current functionality of the recovery system, with which kind of reference systems it works and what recovery options we have.
Then add the link to that confluence page in the ticket https://jira.ess.eu/browse/MBP-247
Once done I will merge this PR. Thanks!!!

@federrg
federrg merged commit 14e90ec into master Jun 22, 2026
2 checks passed
@federrg
federrg deleted the MBP-247-Position-Recovery-Improvements branch June 22, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants