feat(cli): add ax command to dump the accessibility tree - #138
Open
R44VC0RP wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughChangesAccessibility snapshot CLI
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant serve-sim ax
participant ServerState
participant fetchAxSnapshot
participant AXEndpoint
participant normalizeAxTree
User->>serve-sim ax: run command
serve-sim ax->>ServerState: resolve device state
ServerState-->>serve-sim ax: return streamUrl
serve-sim ax->>fetchAxSnapshot: request snapshot
fetchAxSnapshot->>AXEndpoint: request derived /ax URL
AXEndpoint-->>fetchAxSnapshot: return raw AX JSON
fetchAxSnapshot->>normalizeAxTree: normalize RawAxeNode[]
normalizeAxTree-->>fetchAxSnapshot: return AxSnapshot
fetchAxSnapshot-->>serve-sim ax: return snapshot
serve-sim ax-->>User: print JSON
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ran into this while having an agent drive a sim headless — an "open in app?" system dialog was silently eating every deep link we sent, and the only way to detect it was screenshotting and pixel-probing where the button should be. meanwhile the server already captures the full ax tree for the web ui overlay, it just wasn't reachable from the cli.
so this wires it up:
one-shot json dump of the current accessibility snapshot (roles, labels, values, enabled, frames) — same normalized shape the web ui consumes, fetched from the existing per-device /ax endpoint. errors out loud when no server is running or ax is still warming up.
added tests mirroring accessibility-endpoint.test.ts, lint + typecheck pass. the plumbing was already all there, this just exposes it.
Summary by CodeRabbit
New Features
serve-sim ax [-d udid]command to export a simulator’s accessibility tree as JSON.Documentation