Repository navigation
revert: put the vortex crates back on 0.86.1 - #48
Merged
Merged
Conversation
Reverts #35, #36, #37 and #38, the vortex 0.87.0 bumps Renovate opened one crate at a time. 0.87.0 breaks the API both tools that use the facade build against: conformance-gen's generator and four of its examples no longer compile (BtrBlocksCompressorBuilder::default, WriteStrategyBuilder::default, vortex::extension::uuid, FoRScheme, Expression::optimize_recursive), and neither does vxbench-rs (optimize_recursive). CI builds only conformance-gen's verify_written example, which still compiles, so every check stayed green. The pins also stood for more than a dependency: 0.86.1 is the version the corpus, the row vectors, spec/refresh.sh and the reference shim the gates are calibrated under were all produced with. Moving to 0.87.0 is a migration of its own. tokio 1.53.2 (#41) stays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #35, #36, #37 and #38, the vortex 0.87.0 bumps Renovate opened one crate at a time.
Why. 0.87.0 breaks the API the facade users build against, and CI did not see it because it builds only conformance-gen's
verify_writtenexample, which still compiles. Built locally on #46's branch:BtrBlocksCompressorBuilder::default,WriteStrategyBuilder::default,vortex::extension::uuid,FoRScheme,Expression::optimize_recursive);optimize_recursive). Main has been in that state since fix(deps): update rust crate vortex to v0.87.0 #38;The pin also covered more than the dependency. The corpus, the row vectors,
spec/refresh.sh(PINNED_REF) and the reference shim the gates are calibrated under were all produced with 0.86.1. Moving to 0.87.0 needs a migration of its own, and #46 stays open to track it.What is left.
tools/{conformance-gen,row-vectors,vxbench-rs}are byte for byte what they were before #35 (4abfe08), except tokio 1.53.2 from #41, which stays.Not rebuilt locally on this branch. Under the path table from #47, this pull request runs only the cross-check.