Fix EOF delimiter collision in vet-skill workflow#22
Merged
Conversation
Skill content containing literal "EOF" on its own line (e.g. bash heredoc examples) prematurely terminates GitHub Actions multiline output parsing. Replace all hardcoded EOF delimiters with randomized ones via openssl.
Collaborator
Author
|
🚀 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…nged The aggregate job is a required status check, but the workflow only triggered on paths: skills/**. PRs that don't touch skills never ran the workflow, so aggregate never reported, blocking merge forever. Remove the paths filter and gate the AI review jobs on has_skills output instead. The aggregate job always runs but short-circuits to success when no skills were changed.
Deploying everyskill with
|
| Latest commit: |
acb0b65
|
| Status: | ⚡️ Build in progress... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EOFon its own line (e.g. bash heredoc examples) prematurely terminates GitHub Actions$GITHUB_OUTPUTmultiline parsing, breaking theread-skillstep and skipping all downstream AI reviewsEOFdelimiters with randomized ones viaopenssl rand -hex 16across all 4 multiline output sites in the workflowContext
Discovered via PR #21 — the
proof-collabskill includes a bash heredoc example withEOF, which collided with the workflow's output delimiter.Test plan
read-skillstep