fix: serve built editor assets from dist/ directory#55
Open
jessems wants to merge 1 commit into
Open
Conversation
The server reads dist/index.html to inject meta tags and serve it for /d/:slug routes, but never registered dist/ as a static path. This caused the browser to receive 404s for editor.js and all other built assets, leaving the page stuck on "Loading editor...". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dist/index.htmland injects meta tags to serve the editor for/d/:slugroutes, butdist/was never registered as a static path.editor.jsand all other built assets, leaving the page stuck on "Loading editor..." afternpm run build.Fix
Add a single
express.staticmiddleware for thedist/directory, directly after the existingpublic/one.Reproduction
npm install npm run build npm run serve # open http://localhost:4000/d/<slug> → stuck on "Loading editor..."Test plan
npm run build && npm run servePOST /documents