Skip to content

small patches for problems recently introduced#783

Merged
joanise merged 7 commits into
mainfrom
dev.ej/fork-warning-pytest
Apr 1, 2026
Merged

small patches for problems recently introduced#783
joanise merged 7 commits into
mainfrom
dev.ej/fork-warning-pytest

Conversation

@joanise
Copy link
Copy Markdown
Member

@joanise joanise commented Mar 30, 2026

PR Goals

  • tensorboard still needs setuptools<80
  • silence pointless fork warnings
  • stop checking for libsox and sox_effects since we don't use them anymore

Adding more:

  • tuck away more imports to speed up CLI -h
  • improve the pytest configuration

Related PRs

EveryVoiceTTS/FastSpeech2_lightning#134
EveryVoiceTTS/wav2vec2aligner#27

@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Mar 30, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  everyvoice/tests/test_cli.py  43% smaller
  .github/workflows/test.yml  0% smaller
  everyvoice/base_cli/helpers.py  0% smaller
  everyvoice/cli.py  0% smaller
  everyvoice/model/aligner/wav2vec2aligner  0% smaller
  everyvoice/model/feature_prediction/FastSpeech2_lightning  0% smaller
  make-everyvoice-env Unsupported file format
  pyproject.toml Unsupported file format

@joanise joanise requested a review from marctessier March 30, 2026 22:26
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.95%. Comparing base (3456d53) to head (4b871b7).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
everyvoice/base_cli/helpers.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #783      +/-   ##
==========================================
- Coverage   82.98%   82.95%   -0.03%     
==========================================
  Files          47       47              
  Lines        4154     4153       -1     
  Branches      611      611              
==========================================
- Hits         3447     3445       -2     
- Misses        575      576       +1     
  Partials      132      132              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 30, 2026

CLI load time: 0:00.27
Pull Request HEAD: 4b871b75e4556ed318533a8befb66d6e2310269f
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:      1843 |     135984 | everyvoice.cli

Copy link
Copy Markdown
Collaborator

@marctessier marctessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eric!

joanise and others added 7 commits April 1, 2026 11:41
 - get_spectral_transform() makes calls to torchaudio.transforms that
   apparently use fork(), and there's nothing we can do to prevent that, so the
   warning is not helpful. So it's better to silence it with an ignore: rule.

 - ditto the audioop deprecation warning: we've already fixed the issue

 - ditto the srun warning that Lightning issues when it detects SLURM
@joanise joanise force-pushed the dev.ej/fork-warning-pytest branch from 4e9b587 to 4b871b7 Compare April 1, 2026 15:46
@joanise joanise merged commit 44a08ab into main Apr 1, 2026
11 of 13 checks passed
@joanise joanise deleted the dev.ej/fork-warning-pytest branch April 1, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants