[StyleTTS2] feat: add demo and inference integration basics#804
Open
roedoejet wants to merge 4 commits into
Open
[StyleTTS2] feat: add demo and inference integration basics#804roedoejet wants to merge 4 commits into
roedoejet wants to merge 4 commits into
Conversation
Changed Files
|
Contributor
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
==========================================
- Coverage 87.53% 84.81% -2.72%
==========================================
Files 45 46 +1
Lines 4026 4189 +163
Branches 603 626 +23
==========================================
+ Hits 3524 3553 +29
- Misses 365 499 +134
Partials 137 137 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
I previously connected the
everyvoice trainfunctionality with StyleTTS2. This PR integrates StyleTTS2 witheveryvoice demo,everyvoice synthesize, andeveryvoice checkpoint inspectcommands.Fixes?
Part of #686
Feedback sought?
Testing, but also sanity. I think there are actually quite a few places where we tied ourselves a bit too closely to FS2 and its architecture. I think I need some space to be able to tell how to refactor, but any insight is helpful.
I'm mostly looking for high-level analysis about whether the approach to combine repos in this way is reasonable.
Priority?
high
Tests added?
none so far
How to test?
try running
everyvoice synthesize,everyvoice demo, andeveryvoice checkpoint inspect. note, that I don't think this will work on the model you just trained. I'm not adding backwards compatibility support for that, although the hooks are in place for us to be able to handle this in the future in the same way as FS2Confidence?
medium
Version change?
n/a, already bumped to 0.5.0
Related PRs?
EveryVoiceTTS/FastSpeech2_lightning#142
EveryVoiceTTS/StyleTTS2#4