[StyleTTS2] load pretrained checkpoint from HuggingFace#807
Draft
roedoejet wants to merge 1 commit into
Draft
Conversation
|
Review changes with |
roedoejet
force-pushed
the
dev.ap/stts2-hf-checkpoints
branch
from
83961c7 to
e02782e
Compare
roedoejet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Loading pretrained models from within the codebase is messy since we need to handle the paths, and the model checkpoints bloat the package/our git history.
Fixes?
An element of #686
Feedback sought?
Does this look reasonable? I think the "local override" option is still not going to be handled well since it will put a potentially absolute path in the config.
Priority?
high
Tests added?
None
How to test?
if you train a model with this branch, you should see the HF models downloading automatically
Confidence?
medium
Version change?
n/a
Related PRs?
EveryVoiceTTS/StyleTTS2#6
Once accepted, we'll need to clean the git history of any *.t7 or *.pth files