📝 CodeRabbit Chat: Add UIImage Memory Costs to Shimeji Image Cache Entries

[coderabbitai]

Code changes was requested by @Mag1cByt3s.

• fix: CodeRabbit auto-fixes for PR #78 #79 (comment)

The following files were modified:

• Twinskaraoke/Components/Shimeji/ShimejiSpriteView.swift

Summary by Sourcery

Enhancements:

• Calculate and assign an approximate in-memory byte cost for each UIImage stored in the Shimeji image cache.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds memory cost accounting for cached UIImage instances in the Shimeji image cache so NSCache totalCostLimit reflects actual in-memory usage.

Sequence diagram for UIImage caching with memory cost

sequenceDiagram
    participant ShimejiSpriteView
    participant Cache as NSCache
    participant UIImage

    ShimejiSpriteView->>Cache: object(forKey: key)
    alt cached image exists
        Cache-->>ShimejiSpriteView: UIImage
    else cache miss
        ShimejiSpriteView->>UIImage: init(contentsOfFile: url.path)
        UIImage-->>ShimejiSpriteView: image
        ShimejiSpriteView->>ShimejiSpriteView: cost(for: image)
        ShimejiSpriteView->>Cache: setObject(image, forKey: key, cost: cost)
        Cache-->>ShimejiSpriteView: UIImage
    end

Loading

File-Level Changes

Change	Details	Files
Add cost-based caching for UIImage entries to better track memory usage.	Update cache insertion to use NSCache cost parameter when storing images. Introduce a helper method that estimates the in-memory byte size of a UIImage as a decoded RGBA8 bitmap using size and scale. Keep existing cache lookup and removal behavior unchanged.	Twinskaraoke/Components/Shimeji/ShimejiSpriteView.swift

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Important

Review skipped

This PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 418866f1-a003-43aa-9ce2-622b5b1211c9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider deriving the cost from image.cgImage?.bytesPerRow * height when a cgImage is available, as that will more accurately reflect the actual decoded bitmap memory footprint than assuming a fixed 4 bytes per pixel.
• You may want to round pixelsWide and pixelsHigh to integers before casting to Int to avoid truncation from floating-point operations when size or scale are non-integer values.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider deriving the cost from `image.cgImage?.bytesPerRow * height` when a `cgImage` is available, as that will more accurately reflect the actual decoded bitmap memory footprint than assuming a fixed 4 bytes per pixel.
- You may want to round `pixelsWide` and `pixelsHigh` to integers before casting to `Int` to avoid truncation from floating-point operations when `size` or `scale` are non-integer values.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}