Conversation
Signed-off-by: Vladislav Byrgazov <vlados.byrgazov@gmail.com>
Signed-off-by: Vladislav Byrgazov <vlados.byrgazov@gmail.com>
Signed-off-by: Vladislav Byrgazov <vlados.byrgazov@gmail.com>
Signed-off-by: Vladislav Byrgazov <vlados.byrgazov@gmail.com>
Signed-off-by: Vladislav Byrgazov <vlados.byrgazov@gmail.com>
Signed-off-by: Vladislav Byrgazov <vlados.byrgazov@gmail.com>
Signed-off-by: Vladislav Byrgazov <vlados.byrgazov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding with unstable test:
Even if the slice elements are on the heap, &heapPointerX for a local variable returns the address on the stack, which can different, and as result CI was getting different {{expectedPointers}} {{pointers}}.
The problem was that the address of a local stack variable was being taken, not the heap-allocated object.
Root cause:
var heapPointer1 = &heapObjects[1]is local func var on stack, even it is storing global heap addr. So it is stored on the func stack.uintptr(unsafe.Pointer(&heapPointer1))- it is actually taking addr of the func local var on stack,Important: This address is not stable because:
Solution:
Solution is to use global variables or heap-allocated objects - then the uintptr values are always stable.
Error:
So, we can see pretty same right-side addresses, but different stack bytes (61 and 50)