Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several updates to the robot code, focusing on improvements to field constants, swerve drive configuration, and the superstructure command logic. The changes enhance flexibility for field layouts, enable and update swerve drive controls, and refactor the superstructure for clarity and maintainability.
Field and Swerve Drive Updates:
AprilTagFieldLayout, replacing hardcoded values and references to specific reef centers. This makes the code more adaptable to different field configurations. (Constants.java) [1] [2]RobotContainer.java) [1] [2]Superstructure and Command Refactoring:
SuperstructureConstantsfor shared parameters likeHANDOFF_TIME_DELAY, improving code clarity and maintainability. (Constants.java,Superstructure.java) [1] [2] [3]Superstructureclass to reorganize and clarify command methods, move logging annotations, and improve the handling of state-setting commands. Some methods were moved or re-ordered for better grouping, and the use of the new constant for handoff timing was implemented. (Superstructure.java) [1] [2] [3]Superstructureconstructor for improved readability and consistency. (Superstructure.java)Additional Improvements:
RobotContainer.java)RobotStateenum. (RobotState.java) [1] [2]These changes collectively improve the adaptability, readability, and maintainability of the robot codebase.