perf(combos): move gettext-base+curl to the benchmark base (drop per-combo standalone apt)#236
Merged
Merged
Conversation
…bo standalone apt The -standalone build ran apt-get install gettext-base curl on top of each per-combo eval-base — uncacheable (per-combo base) and emulated under QEMU on the arm64 leg. That single RUN was the combo-build bottleneck (~37min/shard; the lean combo itself is pure COPY). Moving the deps into the 6 benchmark bases (built once, natively, cached) makes the standalone layer pure COPY. ROLLOUT: the first release after this MUST set rebuild_bases=true so the bases carry gettext-base before the no-apt standalones build (else standalone lacks envsubst). Later releases reuse the frozen bases. Signed-off-by: Elron Bandel <elron.bandel@ibm.com>
Contributor
Author
|
Verified at runtime (was static-only — lint+grep — before):
Scope: proves the apt-line change + inheritance on a debian-slim base (all 6 bases are debian-based). The full repo base build ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move
gettext-base(+curlwhere missing) into the 6 benchmark bases, and delete the per-comboapt-getfromstandalone.Dockerfile.Why
The
-standalonebuild ranapt-get install gettext-base curlon top of each per-comboeval-base. That singleRUN:FROM eval-base, so it's invalidated for every one of the ~6,400 standalones;buildx --platformon one runner, not native-per-arch).It was the combo-build bottleneck — ~37 min/shard, while the lean combo itself is pure COPY. Moving the deps into the base (built once, natively, cached) makes the standalone layer pure COPY too.
Rollout (important)
The first release after this must set
rebuild_bases=trueso the bases are rebuilt withgettext-basebefore the no-apt standalones build — otherwise a standalone would lackenvsubstat runtime. Subsequent releases reuse the frozen bases.Verified
envsubstpresent from the base) is the next step — a targetedrebuild_bases=truebuild.This is step 1 of "make every build a cheap cache hit"; the staleness gate (#233) is the complementary guarantee.