feat(chart): parameterize image refs with registrySuffix (drop hardcoded "/")#25
Open
elronbandel wants to merge 1 commit into
Open
feat(chart): parameterize image refs with registrySuffix (drop hardcoded "/")#25elronbandel wants to merge 1 commit into
elronbandel wants to merge 1 commit into
Conversation
…ded "/") The chart's three image refs hardcode the category/name separator as "/" (registry/core/otel, /models/<x>, /evals/<x>). That blocks targeting a flattened internal registry — notably an OpenShift imagestream, where a namespace can't hold nested paths and images must collapse to core-otel. Mirror the REGISTRY_SUFFIX parameterization PR #23 added to the Dockerfiles: introduce .Values.registrySuffix (default "/") placed between category and name — registry/<cat>{{ registrySuffix }}<name>. At the default it renders byte-identical to today; --set registrySuffix=- flattens every image to registry/<cat>-<name>. Set it once in a platform overlay (deploy/values-openshift.yaml) rather than per run, matching the existing axis(--set)/platform(--overlay) split. Verified: aime renders byte-identical at defaults; suffix=- yields the flattened imagestream form; all 102 benchmarks pass `cargo test --test helm`.
c0358f2 to
48a047d
Compare
48a047d to
90cd5d1
Compare
90cd5d1 to
01db782
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The shared Helm chart's three image refs hardcode the category/name separator as
/—registry/core/otel,registry/models/<x>,registry/evals/<x>. That blocks rendering against a flattened internal registry, notably an OpenShift imagestream: a namespace can't hold nested paths, so images must collapse tocore-otel. This is the Helm-side gap that #23 closed for the Dockerfiles.What
Mirror PR #23's
REGISTRY_SUFFIXparameterization in the chart. Add.Values.registrySuffix(default"/"), placed between category and name exactly as the Dockerfiles do (${REGISTRY}/<cat>${REGISTRY_SUFFIX}<name>):Byte-identical at the default:
"/"resolves to today's refs exactly. The only new capability is--set registrySuffix=-, which flattens every image toregistry/<cat>-<name>. Like the other platform knobs, it's meant to be set once in an overlay (deploy/values-openshift.yaml) via--overlay, not per run — matching the project's axis(--set)/platform(--overlay) split. No CLI change: the CLI already threads--set registry=and layers overlays; the suffix rides the overlay.Verification
aimerenders byte-identical tomainat defaults (diffempty).--set registry=…/myns --set registrySuffix=-→…/myns/core-otel,…/myns/models-…,…/myns/evals-aime--claude-code(flattened imagestream form).cargo test --test helm.Companion to #23 for the
build --builder oc/ OpenShift-internal-registry path.