docs: point the 4 rich benchmark READMEs at their relocated chart preset#27
Merged
Conversation
The bespoke k8s topology for osworld/tau-bench/visualwebarena/webarena moved from benchmarks/<x>/values.yaml into benchmarks/_chart/presets/<x>.yaml, but their README 'Files' sections still only listed Dockerfile/compose.yaml — a reader had no pointer to where the sidecar/Deployment config now lives. Add a Files entry for each pointing at its preset.
elronbandel
added a commit
that referenced
this pull request
Jun 15, 2026
docs: point the 4 rich benchmark READMEs at their relocated chart preset
elronbandel
added a commit
that referenced
this pull request
Jun 15, 2026
docs: point the 4 rich benchmark READMEs at their relocated chart preset
elronbandel
added a commit
that referenced
this pull request
Jun 15, 2026
docs: point the 4 rich benchmark READMEs at their relocated chart preset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to the self-contained-chart migration (#26). That PR moved the bespoke k8s topology for the 4 rich benchmarks from
benchmarks/<x>/values.yamlintobenchmarks/_chart/presets/<x>.yaml— but their per-benchmarkREADME.md"Files" sections still listed onlyDockerfile/compose.yaml/README.md. A reader of, say, osworld's README (described as needing a desktop sidecar) had no pointer to where that k8s config now lives.What
Add one "Files" entry to each of
osworld,tau-bench,visualwebarena,webarenapointing at itsbenchmarks/_chart/presets/<x>.yaml, noting it's the benchmark's bespoke k8s topology overlaid on the shared chart when rendered with--set benchmark=<x>.4 files, +4 lines. No code, no behavior change.