fix: RITS/hosted_vllm pricing tolerance, AppWorld init lock, env-conf#231
Open
korenLazar wants to merge 1 commit into
Open
fix: RITS/hosted_vllm pricing tolerance, AppWorld init lock, env-conf#231korenLazar wants to merge 1 commit into
korenLazar wants to merge 1 commit into
Conversation
…igurable timeouts, child-process env forwarding Small set of focused fixes uncovered while running CE-Manager + Mnemex sweeps on AppWorld with RITS-hosted models. Each fix is independently useful for any user running: - benchmarks with parallel sessions on AppWorld, - models that LiteLLM has no pricing for (e.g. hosted_vllm/*, rits/*), - subprocess (venv) runners with slow model-health endpoints, - subprocess runners that need PYTHONPATH or locale forwarded. Bugfixes: - benchmarks/appworld/appworld_eval.py: serialise AppWorld(__init__) under a class-level threading.Lock. AppWorld's init clears a global cache dict that races under parallel workers, producing 'dictionary changed size during iteration'. New tests/benchmarks/test_appworld_session_init_lock.py. - integrations/litellm/trace_logger.py: guard against ctx is None or ctx.otel_context is None in start_span_context_from_kwargs. Avoids AttributeError when LiteLLM emits trace events outside an Exgentic context. Coverage in tests/observers/test_otel.py. - observers/handlers/results.py + utils/cost.py: tolerate models that litellm.cost_calculator has no pricing for (currently hosted_vllm/* and rits/*). Previously crashed the entire results pipeline with 'No pricing info found for model'; now returns zero-cost and logs a warning. Coverage in tests/utils/test_cost.py. Configurability: - adapters/runners/venv.py: EXGENTIC_VENV_HEALTH_TIMEOUT and EXGENTIC_VENV_TRANSPORT_TIMEOUT override the previously-hardcoded defaults (360s / 600s), needed for slow inference endpoints. - agents/smolagents/base_instance.py: EXGENTIC_MODEL_HEALTH_TIMEOUT flows into check_model_accessible_sync. - adapters/runners/_utils.py: forward PYTHONPATH, HOME, USER, LANG, LC_ALL, and CE_MANAGER_* env vars to subprocess runners so optional packages and locale survive the venv hop. Coverage in tests/adapters/runners/test_utils.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…igurable timeouts, child-process env forwarding
Small set of focused fixes uncovered while running CE-Manager + Mnemex sweeps on AppWorld with RITS-hosted models. Each fix is independently useful for any user running:
Bugfixes:
Configurability: