Don't delete the html/builds directory#13
Merged
kevinbackhouse merged 1 commit intoExiv2:mainfrom Aug 30, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes broken download links on the exiv2.org website by preventing the deletion of the html/builds directory during the cleanup process. The issue was that the downloads.sh script copies files to this directory, but the workflow was inadvertently removing it.
- Removes
$EXIV2WEB/html/buildsfrom the cleanup command to preserve downloaded build artifacts - Maintains cleanup of temporary files and the
html/releasesdirectory
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kmilos
approved these changes
Aug 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this is why the links on https://exiv2.org/download.html don't work. We're deleting the
html/buildsdirectory, which is where they're copied to by thedownloads.shscript.