Skip to content

[Import] Reference-lookup mappings can never pass validation — the guided flow deadlocks #50

Description

@Exotic209093

Severity

High — the advertised "Reference lookup" mapping feature is unusable end to end.

What happens

A lookup mapping in externalId/relatedField mode produces mapped keys like Account: { External_Key__c: … }. The validator looks keys up in the describe fieldMap by field name (AccountId), finds no field named Account, and emits Unknown field "Account" for every row. Both validate() and the dry run use this validator, and the Review confirm button is disabled until validationErrors.length === 0 — so any import using a reference lookup can never reach the push.

Evidence

  • src/data/validators/index.ts:58-67
  • src/data/mappers/index.ts:139 (relationship key shape)
  • src/ui/screens/DataPushScreen.tsx:1038 (confirm gate)

Suggested fix

Teach the validator to recognize relationship keys (match field.relationshipName / __r names and validate the nested match field) or skip nested-object values.

Environment

Commit 74cf21b (main), WaveLink 0.6.0. Found in the 2026-08-31 adversarial audit (code-verified).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions