fix: improve export fidelity for CSV, Excel, and query results (#69, #70, #72, #73, #76, #79, #80) - #119
Conversation
, #72, #73, #76, #79, #80) - Fix field mapping in ExportModal for accurate column output - Preserve data types during bulk API export - Handle special characters in download filenames - Correct record count in QueryScreen exports - Add unit tests for queryAll pagination edge cases Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0f484e1e56
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| header: true, | ||
| delimiter: ',', | ||
| skipEmptyLines: true, | ||
| dynamicTyping: true, |
There was a problem hiding this comment.
Enabling dynamicTyping for every column makes Papa Parse infer types solely from CSV contents, without Salesforce field metadata. Consequently, text values such as postal codes or external IDs containing 00123 become numbers and lose leading zeroes, while ISO datetime strings become Date objects; those Date objects are subsequently omitted by flattenRecord because it traverses them with Object.entries. Bulk-query exports can therefore silently corrupt text fields or entirely lose datetime columns, so conversion needs to be schema-aware or the CSV values should remain strings.
Useful? React with 👍 / 👎.
| if (!seen.has(fullKey)) { | ||
| seen.add(fullKey); | ||
| cols.push(fullKey); | ||
| } | ||
| collectKeys(v, fullKey, seen, cols); |
There was a problem hiding this comment.
For scheduled queries containing relationships, this adds headers such as Account.Name, but runSchedule stores the original nested records and later calls exportRecords(snapshot.records, snapshot.columns, ...); every exporter reads values with record[column]. Since the raw row has record.Account.Name rather than record['Account.Name'], the new dotted columns are blank in downloaded snapshots, while the added parent Account column still serializes the object incorrectly. Flatten the records before storing/exporting them, or resolve dotted paths instead of emitting unmatched headers.
Useful? React with 👍 / 👎.
1 participant
Summary
Improves export fidelity across CSV, Excel, and query result exports.
Issues Fixed
Changes
🤖 Generated with Claude Code