-
Notifications
You must be signed in to change notification settings - Fork 0
fix(accessibility): improve ARIA attributes and keyboard navigation across UI components #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,13 +42,14 @@ export function MigrationProgressDashboard(props: { | |
| const barColor = status === 'error' ? 'var(--wl-danger)' : progress.done ? 'var(--wl-success)' : 'var(--wl-accent)'; | ||
|
|
||
| return ( | ||
| <div class="wl-card"> | ||
| <div class="wl-card" role="region" aria-label="Migration progress dashboard" aria-live="polite"> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
While a push is processing, Useful? React with 👍 / 👎. |
||
| <div class="wl-cardHeader"> | ||
| <h2>Migration Progress</h2> | ||
| <div style="display:flex;align-items:center;gap:10px"> | ||
| <span | ||
| class="wl-pill" | ||
| style={`color:${badge.color};border-color:${badge.color}55`} | ||
| aria-label={`Status: ${badge.label}`} | ||
| > | ||
| {badge.label} | ||
| </span> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| /** | ||
| /** | ||
| * Tree of objects with checkboxes and edge labels for the clone wizard. | ||
| * | ||
| * What this file does: | ||
|
|
@@ -69,7 +69,7 @@ export function RelationshipTree(props: RelationshipTreeProps): VNode { | |
| }, [graph.edges]); | ||
|
|
||
| return ( | ||
| <div class="wl-relationshipTree"> | ||
| <div class="wl-relationshipTree" role="tree" aria-label="Object relationship tree"> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When assistive technology encounters this container, it expects owned Useful? React with 👍 / 👎. |
||
| {nodeNames.length === 0 && ( | ||
| <div class="wl-muted" style="padding:8px"> | ||
| No objects in the relationship graph. | ||
|
|
@@ -85,11 +85,7 @@ export function RelationshipTree(props: RelationshipTreeProps): VNode { | |
| {/* Node */} | ||
| <div class="wl-relNode" data-cycle={inCycle ? 'true' : undefined}> | ||
| <label style="display:flex;align-items:center;gap:8px;cursor:pointer;flex:1"> | ||
| <input | ||
| type="checkbox" | ||
| checked={selectedObjects.has(name)} | ||
| onChange={() => onToggleObject(name)} | ||
| style="accent-color:var(--wl-accent)" | ||
| <input type="checkbox" checked={selectedObjects.has(name)} onChange={() => onToggleObject(name)} style="accent-color:var(--wl-accent)" aria-label={`Select ${name} for cloning`} | ||
| /> | ||
| <span style="font-weight:700;font-size:13px">{name}</span> | ||
| </label> | ||
|
|
@@ -129,3 +125,4 @@ export function RelationshipTree(props: RelationshipTreeProps): VNode { | |
| </div> | ||
| ); | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For screen-reader users,
role="img"makes this entire subtree a single image whose accessible name is only “Field analytics chart showing N fields”; the descendant field names, population percentages, uniqueness rates, and distinct counts are treated as image contents rather than readable data. Since the surrounding screen does not expose those per-field metrics elsewhere, remove the image role or provide an alternative that includes every metric.Useful? React with 👍 / 👎.