feat(ux): improve keyboard shortcuts and onboarding flow - #124
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93d802d173
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Onboarding modal is no longer auto-shown on first launch. Users can | ||
| // open it from the Home "Getting started" surface when they choose. |
There was a problem hiding this comment.
On a fresh install, showOnboarding remains initialized to false after this effect stops loading onboarding progress, and there is no setShowOnboarding(true) anywhere else in AppRoot; HomeScreen also has no tutorial control. Consequently the stated opt-in “Getting started” surface does not exist and new users can reach the wizard only by discovering Help's “Restart Tutorial” action.
Useful? React with 👍 / 👎.
| ), | ||
| shortcutRegistry.register( | ||
| { id: 'toggle-undo', defaultKeys: 'ctrl+z', description: 'Toggle undo panel', scope: 'global' }, | ||
| { id: 'toggle-undo', defaultKeys: 'ctrl+shift+z', description: 'Toggle undo panel', scope: 'global' }, |
There was a problem hiding this comment.
When an input or other editable control is focused on macOS, Command+Shift+Z is the native redo command; normalizeKeys maps Command/Meta to ctrl, so this new default matches it. The editable-target guard explicitly allows shifted chords, causing WaveLink to prevent the native redo and toggle its undo panel instead.
Useful? React with 👍 / 👎.
| if (isEditable && !e.shiftKey && !e.altKey) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Whenever focus is in an input, textarea, select, or contenteditable element, this condition suppresses every shortcut lacking Shift or Alt rather than only native editing chords. For example, the globally scoped Command/Ctrl+K command-palette shortcut now stops working while users are editing a SOQL field or search box; the exemption should be based on known editing bindings such as undo/redo instead.
Useful? React with 👍 / 👎.
| name: 'Import', | ||
| description: 'Upload files, map fields, push records, and review push history.', | ||
| filter: (s) => s.category === 'data-push', | ||
| filter: (s) => s.category === 'import', |
There was a problem hiding this comment.
After renaming this display category to Import, getTopicsForCategory looks it up in CATEGORY_NAME_MAP, which still contains only Data Push -> data-push. The lookup therefore falls back to the capitalized string Import, while the topics now use lowercase import, leaving this card empty and hiding it entirely whenever a search is active.
Useful? React with 👍 / 👎.
1 participant
Summary
Addresses #84, #85 - ux-shortcuts-onboarding
🤖 Generated with Claude Code