fix(logging): add tRPC context to propagate URL params into logs#748
Merged
danadajian merged 2 commits intomainfrom Mar 26, 2026
Merged
fix(logging): add tRPC context to propagate URL params into logs#748danadajian merged 2 commits intomainfrom
danadajian merged 2 commits intomainfrom
Conversation
Introduces a Context type parsed from the Referer header once per request. The onError handler now uses ctx.urlParams instead of re-parsing the Referer itself. acceptVisualChanges receives ctx so its INFO log automatically includes all SPA URL params (owner, repo, bucket, commitHash, etc.) without manually listing each field. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
🎉 This PR is included in version 1.41.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contexttype (parsed from theRefererheader once per request) that makes SPA URL params available server-side —commitHash,owner,repo,bucket, etc.onErrorhandler now usesctx.urlParamsinstead of re-parsing theRefererheader itself, consolidating that logic in one placeacceptVisualChangesnow receivesctxso itsINFOlog automatically includes all URL params without manually enumeratingowner,repo,hash, etc.Changes
app/backend/src/context.ts(new) —Contexttype andcreateContextfunction; parsesRefererheader intourlParamsapp/server.ts— passescreateContexttocreateBunHttpHandler;onErrorusesctx?.urlParamsinstead of inline Referer parsingapp/backend/src/router.ts—initTRPC.context<Context>().create(); passesctxtoacceptVisualChangesmutationapp/backend/src/acceptVisualChanges.ts— acceptsctx: Contextas second param; spreadsctx.urlParamsinto theVISUAL_CHANGES_ACCEPTEDinfo logapp/backend/test/acceptVisualChanges.test.ts— updated call sites to pass{ urlParams: {} }as ctxTest plan
acceptVisualChangesand verify the serverINFOlog includesowner,repo,bucket,commitHashfrom the browser URLERRORlog still includes URL params viactx.urlParamsbunx nx test backendpassesGenerated with Claude Code