Fix/lazy load handler#354
Merged
Merged
Conversation
patduin
commented
Oct 29, 2025
| Socket socket = ((TSocket) transport).getSocket(); | ||
| log.debug("Received a connection from ip: {}", socket.getInetAddress().getHostAddress()); | ||
| } | ||
| CloseableIHMSHandler baseHandler = federatedHMSHandlerFactory.create(); |
Contributor
Author
There was a problem hiding this comment.
This gets created when a tcp connection is made (LoadBalancer might do this for livelyness check), the handles won't get invoked until a thrift client does a real call, so it makes sense to defer the creation of this when get a real invocation.
This will reduce the clutter in the logs where it looks like we are getting a lot of calls even if we aren't.
javsanbel2
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
🔗 Related Issues