Fixed bug where alters that rely on state are retried but shouldn't#356
Merged
Conversation
abhimanyugupta07
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered bug when using Iceberg no locking strategy.
Bug:
Client sends an alter_table with using EnvironmentContext and set expected key's and values properties:
expected_parameter_keyandexpected_parameter_value.WD sends Alter to HMS but connection breaks down and TTransportException is thrown. Alter actually succeeds in HMS.
WD doesn't know about success so naively retries, but now the alter fails due to expected values differ.
Client receives failed alter. (Although it was correctly applied in HMS).
Solution:
WD shouldn't retry but just return the connection exception to the client who can then act as it pleases.