Skip to content
This repository was archived by the owner on Feb 12, 2026. It is now read-only.

refactor: remove oauth endpoints skillup - #35

Merged
vlghpp merged 1 commit into
developfrom
refactor/remove-oauth-skillup-endpoints
Dec 6, 2025
Merged

vlghpp merged 1 commit into
developfrom
refactor/remove-oauth-skillup-endpoints

Conversation

@vlghpp

@vlghpp vlghpp commented Dec 5, 2025 •

Copy link
Copy Markdown
Contributor

Modelo de Pull Request

Descrição

Removendo os endpoints do skillup project que agora não são mais necessários.

Tipos de Mudanças

  • fix: correção de bug
  • feat: nova funcionalidade
  • docs: mudanças na documentação
  • chore: mudanças no processo de build ou ferramentas auxiliares
  • refactor: refatoração de código existente
  • test: adição ou modificação de testes
  • perf: melhorias de performance
  • ci: mudanças em arquivos de configuração de CI/CD

Como o teste foi realizado?

  • [] Testes unitários (sucesso e falha)
  • Teste em máquina local
  • Teste em ambiente de homologação
  • Teste em ambiente de produção

Checklist:

  • Meu código segue as diretrizes de estilo deste projeto
  • Eu realizei uma autoavaliação do meu próprio código
  • Eu comentei meu código, especialmente em áreas de difícil compreensão
  • Eu adicionei documentação conforme necessário
  • Minhas mudanças não geram novos avisos de compilação (warnings)
  • Eu adicionei testes para cobrir minhas mudanças
  • Todos os testes novos e existentes passam localmente com minhas mudanças
  • Qualquer dependência de terceiros foi atualizada e documentada

Summary by CodeRabbit

  • Bug Fixes
    • Google OAuth sign-in authentication has been removed from the application. Users will no longer be able to authenticate using their Google credentials through this service.
    • Removed the authentication callback handler that previously managed redirect logic and error handling.
    • Cleaned up related test cases and coverage for the removed authentication integration.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Dec 5, 2025 •

Copy link
Copy Markdown

Walkthrough

Removed Google OAuth authentication integration from the SkillUp service, including the callback handler in the controller, Google OAuth routes and passport import, and corresponding test case. The changes delete authentication flow components without adding replacement logic.

Changes

Cohort / File(s) Summary
Google OAuth removal
src/controllers/SkillUpController.js, src/routes/skillup.js, tests/routes/skillup.test.js
Deleted authSkillupCallback method from controller; removed passport import and Google OAuth routes (/auth/google, /auth/callback) from router; removed test for callback redirect.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Verify no other code paths or middleware depend on the removed authSkillupCallback method
  • Confirm removal of OAuth routes doesn't break integration tests or client-side auth flows

Poem

🐰 Google's gates have gently closed,
OAuth roads are decomposed,
SkillUp streamlines as it goes—
Simpler auth now grows! 🌱

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'refactor: remove oauth endpoints skillup' directly and clearly summarizes the main change: removal of OAuth endpoints from the skillup module.
Description check ✅ Passed The description follows the template structure, includes a brief summary, correctly marks the change type as refactor, documents local testing, and completes relevant checklist items, though some sections remain unchecked.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/remove-oauth-skillup-endpoints

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7ebe832 and 2c95d2f.

📒 Files selected for processing (3)
  • src/controllers/SkillUpController.js (0 hunks)
  • src/routes/skillup.js (0 hunks)
  • tests/routes/skillup.test.js (0 hunks)
💤 Files with no reviewable changes (3)
  • src/controllers/SkillUpController.js
  • tests/routes/skillup.test.js
  • src/routes/skillup.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vlghpp
vlghpp merged commit 8dbe62e into develop Dec 6, 2025
5 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Dec 16, 2025
10 of 20 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants