Repository navigation
Conversation
DHIS2 >= 2.41 loads apps inside an iframe and already renders its own header bar, so the app's own HeaderBar produced a duplicate. Only render it when the app is not embedded (window.self === window.top), matching the fix applied in training-app.
The build-webapp script was merged into build a while ago; the README still pointed at the old, now nonexistent script name.
BundleMonNo change in files bundle size Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
xurxodev
approved these changes
Aug 19, 2026
xurxodev
left a comment
Contributor
There was a problem hiding this comment.
Thanks @anagperal
Tested in local and installed in 2.43 play
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 References
📝 Implementation
🎨 Screenshots
🔥 How to test it? (If there is any special consideration or the reviewer does not know how to test it)
📑 Others
Build the app install and check
Check also running it in local env