Skip to content

Fix double header bar - #85

Open
anagperal wants to merge 2 commits into
developmentfrom
fix/double-header-bar
Open

anagperal wants to merge 2 commits into
developmentfrom
fix/double-header-bar

Conversation

@anagperal

@anagperal anagperal commented Jul 20, 2026 •

Copy link
Copy Markdown

📌 References

📝 Implementation

  • DHIS2's global shell (>2.41) renders its own header bar when the app is embedded in an iframe, duplicating the HeaderBar this app already renders. Only render it when the app is loaded at the top level.
  • fix yarn build in README

🎨 Screenshots

Screenshot from 2026-07-20 14-25-36

🔥 How to test it? (If there is any special consideration or the reviewer does not know how to test it)

📑 Others

Build the app install and check
Check also running it in local env

DHIS2 >= 2.41 loads apps inside an iframe and already renders its own
header bar, so the app's own HeaderBar produced a duplicate. Only
render it when the app is not embedded (window.self === window.top),
matching the fix applied in training-app.
The build-webapp script was merged into build a while ago; the
README still pointed at the old, now nonexistent script name.
@bundlemon

bundlemon Bot commented Jul 20, 2026

Copy link
Copy Markdown

BundleMon

No change in files bundle size

Groups updated (1)
Status Path Size Limits
✅ Build Folder
./**/*
4.03MB (-223.45KB -5.14%) +20%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@anagperal
anagperal requested a review from Ramon-Jimenez July 20, 2026 13:49

@xurxodev xurxodev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anagperal

Tested in local and installed in 2.43 play

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants