chore(deps): bump react and @types/react - #650
dependabot[bot] wants to merge 2 commits into
Conversation
dependabot
Bot
added
dependencies
Bumps [react](https://github.com/facebook/react/tree/HEAD/packages/react) and [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react). These dependencies needed to be updated together. Updates `react` from 19.2.4 to 19.2.7 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/react/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.7/packages/react) Updates `@types/react` from 19.2.14 to 19.2.17 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-version: 19.2.17 dependency-type: direct:development update-type: version-update:semver-patch - dependency-name: react dependency-version: 19.2.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
11f7956 to
294053c
Compare
birme
left a comment
birme
left a comment
There was a problem hiding this comment.
Verdict: Needs Changes
builds, lint, and prettier pass, but tests and both e2e shards fail — a real behavioral regression introduced by the React bump, not a config/tooling issue. A React version change that red-lines the unit and e2e suites must not be merged as-is; the failing tests need to be investigated and the app code/tests updated to match the new React behavior first. Routing to a human / feature-writer to triage the test failures before this can land. Not merging on red CI.
birme
left a comment
birme
left a comment
There was a problem hiding this comment.
Reviewed via daily-backlog-pr (Phase 3.5). This react / @types/react bump currently fails CI (build/lint/tests red), so it can't be merged as-is — a major-version bump like this needs the accompanying code/flat-config migration before it will pass. Requesting changes until CI is green; a maintainer should either land the migration on this branch or close it in favor of a coordinated upgrade.
birme
left a comment
birme
left a comment
There was a problem hiding this comment.
Independent review (daily-backlog-pr Phase 3.5, dependabot orphan PR triage).
Verdict: Needs Changes — failing CI (major version bump)
This is a React major-version bump and the tests check is failing. Major upgrades need a human owner to work through the migration; we do not merge with failing CI. Flagging for maintainer attention rather than auto-handling.
1 participant
Bumps react and @types/react. These dependencies needed to be updated together.
Updates
reactfrom 19.2.4 to 19.2.7Release notes
Sourced from react's releases.
Changelog
Sourced from react's changelog.
Commits
6117d7cVersion 19.2.7 (#36591)eaf3e95Version 19.2.623f4f9f19.2.5Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for react since your current version.
Updates
@types/reactfrom 19.2.14 to 19.2.17Commits