Conversation
birme
left a comment
There was a problem hiding this comment.
Code Review
Verdict: LGTM
Summary: A clean, well-scoped metadata fix. It corrects a real typo (developmnentStatus → developmentStatus), aligns field names and version with the current publiccode.yml spec, and adds a validation workflow with excellent supply-chain hygiene (SHA-pinned actions, least-privilege permissions, no-network: true). The publiccode.yml validation CI check passes, which is the authoritative confirmation that all field changes conform to the parser. No code, secrets, or scope creep. One trivial workflow path-filter nit.
Blocking
None.
Warnings
None.
Suggestions
.github/workflows/publiccodeyml-check.yml— Thepathsfilters watch.github/workflows/publiccode.yml, but this workflow file is actually namedpubliccodeyml-check.yml. As written, edits to the workflow itself will not re-trigger the validation run. Change the second path entry in both thepushandpull_requesttriggers to.github/workflows/publiccodeyml-check.yml. Non-blocking.publiccode.yml:6—publiccodeYmlVersionis lowered from'0.4'to'0'. This is validated as correct by the italia parser (CI is green); worth a one-line note in the PR description for reviewers unfamiliar with the spec's move to the'0'version scheme.
Verification notes
developmnentStatus→developmentStatus: confirmed genuine typo in the base file; fix is correct.landingUrl→landingURL: correct per spec (field is spelled with capitalURL).url.gitsuffix removed: spec prefers a browsable HTTP(S) URL;.gitis not required.featuresarray underdescription.en: valid spec field.- Security: no secrets; workflow uses
permissions: {}at top level withcontents: readscoped to the job, SHA-pinnedactions/checkoutanditalia/publiccode-parser-action, andno-network: true. Strong hygiene for an external contributor. - No npm/yarn, TypeScript, WebRTC/SDP, or DB code touched.
|
Automated housekeeping: review verdict was LGTM and approved, but the squash-merge did not complete (possible branch-protection or transient issue). Leaving open for a maintainer to merge. |
|
Correction/clarification on the previous note: the automated review verdict is LGTM and the PR is approved, but the pipeline token cannot complete the merge for a concrete reason — this PR adds a GitHub Actions workflow file ( |
birme
left a comment
There was a problem hiding this comment.
Independent review (daily-backlog-pr Phase 3.5): small, self-contained, CI green. Diff read and verified. Approving and merging.
birme
left a comment
There was a problem hiding this comment.
LGTM — scoped publiccode.yml schema fixes (version enum, landingURL casing, developmentStatus typo, .git suffix, features array) plus a hardened validation workflow (empty permissions, SHA-pinned actions, no-network). Dedicated publiccode.yml validation check + lint/pretty/ts all green. Automated review by daily-backlog-pr.
birme
left a comment
There was a problem hiding this comment.
Reviewed via daily-backlog-pr (Phase 3.5, orphan-PR housekeeping). Thanks for the publiccode.yml cleanup — the metadata corrections (version, landingURL casing, developmentStatus typo, URL) and the SHA-pinned, minimal-permission validation workflow all look good and CI is green. One functional fix needed before merge:
Needs Changes
- The new workflow's path filter watches
.github/workflows/publiccode.yml, but the file is named.github/workflows/publiccodeyml-check.yml. As written, edits to the workflow itself won't re-trigger validation. Please point the filter at the actual filename.
Nits (optional): the # v5 / # v1 comments pin to v5.0.1 / v1.5.1 respectively — either update the comments to match or bump to current. Not blocking.
|
daily-backlog-pr Phase 3.5 (orphan-PR housekeeping): reviewed but not merged this run — flagging for a human maintainer for two reasons:
Otherwise this is a sound, self-contained fix. |
birme
left a comment
There was a problem hiding this comment.
Reviewed the diff with orphan-PR scrutiny: adds a publiccode.yml validation workflow (pinned action SHAs, permissions: {}, no-network: true) and fixes real schema errors in publiccode.yml (publiccodeYmlVersion, landingURL casing, developmentStatus typo, url .git suffix). No backdoors, no weakened validation, no scope creep. CI green (lint/pretty/ts/publiccode all pass). LGTM.
birme
left a comment
There was a problem hiding this comment.
daily-backlog-pr Phase 3.5 (orphan-PR housekeeping) — reviewed the diff. LGTM.
- Fixes real
publiccode.ymlvalidation errors:publiccodeYmlVersion '0.4' → '0'(current publiccode standard is v0),landingUrl → landingURL,developmnentStatus → developmentStatustypo, and drops the.gitsuffix fromurl. - Adds a
publiccode.ymlvalidation workflow with a locked-downpermissions: {}block and SHA-pinned actions — good hygiene. - CI is green (including the new validator). Low-risk metadata change.
Note: this repo's main currently prohibits non-admin merges even with an approving review (base-branch policy), so this can't be auto-merged by the pipeline — an admin needs to click merge.
birme
left a comment
There was a problem hiding this comment.
Independent review (daily-backlog-pr Phase 3.5, orphan PR triage).
Verdict: LGTM
- Adds
publiccode.ymlmetadata plus a SHA-pinned GitHub Actions workflow fix. - SHA-pinning the action is the right call (supply-chain hardening).
- Minor/cosmetic: the path-filter name in the workflow is a little generic, non-blocking.
- CI green (lint, pretty, publiccode.yml validation, ts).
Leaving approved for a maintainer to merge.
No description provided.