Skip to content

fix: update Shaka Player to use attach() method (fixes #120) #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LucasMaupin merged 1 commit into from
Mar 18, 2026
Merged

fix: update Shaka Player to use attach() method (fixes #120) #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/core/src/tech/ShakaTech.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export default class DashPlayer extends BaseTech {
constructor(opts: IWebPlayerOptions) {
super(opts);
shaka.polyfill.installAll();
this.shakaPlayer = new shaka.Player(this.video);
this.shakaPlayer = new shaka.Player();

const restrictToElementSize = !opts.disablePlayerSizeLevelCap;
this.shakaPlayer.configure({ abr: { restrictToElementSize: restrictToElementSize } });
Expand All @@ -28,12 +28,15 @@ export default class DashPlayer extends BaseTech {
);
}

load(src: string): Promise<void> {
async load(src: string): Promise<void> {
super.setDefaultState();
return this.shakaPlayer.load(src).catch((error) => {
try {
await this.shakaPlayer.attach(this.video);
await this.shakaPlayer.load(src);
} catch (error) {
this.handleLoadError(error);
throw error;
});
}
}

private handleLoadError(error: any): void {
Expand Down
Loading