Migrate to existing sframe crate - #48
Open
TobTheRock wants to merge 1 commit into
Open
Conversation
Switching the custom sframe implementation to the public sframe crate. This library is fully compliant to the latest spec (RFC 9605). It also allows swapping the crypto backend. Switched to ring as it more performant than rust crypto and the AES ctr modes are not used. The sframe-gbp public API was left untouched, but as derived keys differ from the old build, all peers must upgrade together, so this is breaking
TobTheRock
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I have stumbled across your project by chance and have noticed your sframe implementation. As I was anyway looking for an opportunity to test the MLS definitions of my sframe crate, I did the exercise to replace it here.
This brings the following benefits:
ringlibrary proves to be more performant thanrust-cryptoFeel free to drop if you prefer owning the stack with your own implementation.
Type of change
Testing
cargo test --workspacepassesTestSFrameE2EE, real MLS + FFI, gapAudio.ts)Checklist
feat:,fix:,docs:, …)cargo fmt --allandcargo clippy --all-targets -- -D warningsclean