feat: add support for keyword mappers in custom mode JSON#11
Open
pepijnve wants to merge 1 commit intoF0rce:masterfrom
Open
feat: add support for keyword mappers in custom mode JSON#11pepijnve wants to merge 1 commit intoF0rce:masterfrom
pepijnve wants to merge 1 commit intoF0rce:masterfrom
Conversation
When the value for the `token` key of a rule is an object, this will now get converted to a keyword mapper. The token object should contain the keys `map`, `defaultToken`, `ignoreCase`, and `splitChar`
pepijnve
force-pushed
the
keyword_mapper
branch
from
957c99a to
475b51d
Compare
Owner
|
@pepijnve thanks for the PR. Just out of curiousity, do you think that it could be worth, if I update Ace to the latest version as well. The Ace Vaadin Webcomponent hasn’t received the love it used to get. If so, I would work on in that weekend and merge on monday. Or would you need the changes faster, that I fully test out your changes, and create a seperate PR for upgrading Ace and switching to a Vite build ? |
Author
|
If it's not too much work that would be nice. There's no need to rush the mode changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the value for the
tokenkey of a rule is an object, this will now get converted to a keywordmapper. The token object should contain the keys
map,defaultToken,ignoreCase, andsplitChar