Add support for single-quoted multiline values in env loader#3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #1
👋 TL;DR
Removed unused schema generation code and
writeFileSyncimport fromdb-pull-dump.ts, and added support for single-quoted multiline values infirebase-env.sh.🔎 Details
The changes consist of two main parts:
Database Script Cleanup: Removed unused
writeFileSyncimport and the entiregenerateSchemaSqlfunction with its helpergetColumnTypefromdb-pull-dump.tssince they were no longer being used. This includes:Shell Script Enhancement: Enhanced
firebase-env.shto properly handle multiline environment variables that use single quotes (') in addition to the existing double quote (") support. The fix adds:✅ How to Test
Database Script:
escapeCopyValuefunction works correctlyShell Script:
🥜 GIF